fix(rsc): fix client reference preload when group chunk re-exports client components from entry chunk #768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hi-ogawa
changed the base branch from
main
to
08-24-feat_rsc_merge_client_reference_chunks_based_on_server_chunk_usage
commit: |
hi-ogawa
changed the title
hi-ogawa
added a commit
to hi-ogawa/waku
that referenced
this pull request
Aug 24, 2025
hi-ogawa
changed the base branch from
08-24-feat_rsc_merge_client_reference_chunks_based_on_server_chunk_usage
to
main
hi-ogawa
force-pushed
the
08-24-fix_rsc_fix_client_reference_dependency_manifest
branch
from
df80c00 to
48abd80
Compare
hi-ogawa
changed the title
hi-ogawa
deleted the
08-24-fix_rsc_fix_client_reference_dependency_manifest
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#766 broke modulepreload of group virtual chunk when the actual client references are included in entry chunk. For example, in wakujs/waku#1653, Waku's client entry chunk itself includes waku's internal client components (e.g. Link) and group virtual re-exports them.