Skip to content

fix(rsc): fix CSS HMR with ?url #776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 25, 2025
Merged

fix(rsc): fix CSS HMR with ?url #776

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5afe2de
fix(rsc): fix CSS HMR with `?url`
hi-ogawa Aug 25, 2025
aa60efd
Merge branch 'main' into 08-25-fix_rsc_fix_css_hmr_with_url_
hi-ogawa Aug 25, 2025
cf1d104
fix: tweak
hi-ogawa Aug 25, 2025
9764bce
chore: cleanup
hi-ogawa Aug 25, 2025
16dbefe
chore: no precedence for this test
hi-ogawa Aug 25, 2025
d827493
Merge branch 'main' into 08-25-fix_rsc_fix_css_hmr_with_url_
hi-ogawa Aug 25, 2025
7aedb19
test: wip
hi-ogawa Aug 25, 2025
0d6d66f
test: extend CSS HMR tests for URL-based CSS files
hi-ogawa Aug 25, 2025
1dafe43
test: update
hi-ogawa Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions packages/plugin-rsc/examples/basic/src/routes/css-queries/client.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,22 +12,15 @@ export function TestCssQueriesClient(props: {
}) {
const [enabled, setEnabled] = React.useState(false)

function urlWithHmr(href: string) {
if (import.meta.hot) {
href += '?t=' + Date.now()
}
return href
}

return (
<div>
<button onClick={() => setEnabled(!enabled)}>test-css-queries</button>
{enabled && (
<>
<link rel="stylesheet" href={urlWithHmr(cssUrl)} />
<link rel="stylesheet" href={cssUrl} />
<style>{cssInline}</style>
<style>{cssRaw}</style>
<link rel="stylesheet" href={urlWithHmr(props.serverUrl)} />
<link rel="stylesheet" href={props.serverUrl} />
<style>{props.serverInline}</style>
<style>{props.serverRaw}</style>
</>
Expand Down
4 changes: 3 additions & 1 deletion packages/plugin-rsc/src/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,7 +481,9 @@ export default function vitePluginRsc(
if (this.environment.name === 'client') {
// filter out `.css?direct` (injected by SSR) to avoid browser full reload
// when changing non-self accepting css such as `module.css`.
return ctx.modules.filter((m) => !m.id?.includes('?direct'))
return ctx.modules.filter(
(m) => !(m.id?.includes('?direct') && !m.isSelfAccepting),
)
Comment on lines +484 to +486
Copy link
Contributor Author

@hi-ogawa hi-ogawa Aug 25, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed by targeting non self-accepting case specifically. This likely means HMR doesn't work for xxx.module.css?url, but let's just postpone dealing with that edge case.

}
}

Expand Down
Loading