perf: remove unnecessary export checks #798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
added
the
p2-nice-to-have 🍰
sapphi-red
commented
Aug 29, 2025
|
|
||
| function predicateOnExport(ignoredExports, moduleExports, predicate) { | ||
| for (const key in moduleExports) { | ||
| if (key === '__esModule') continue |
There was a problem hiding this comment.
Since moduleExports is a module namespace, the __esModule marker won't exist. If you have export const __esModule = something, it should be checked.
Comment on lines
-658
to
-659
| const desc = Object.getOwnPropertyDescriptor(moduleExports, key) | ||
| if (desc && desc.get) return key |
There was a problem hiding this comment.
Since moduleExports is a module namespace, all properties are not a sideeffectful getter.
hi-ogawa
approved these changes
Aug 29, 2025
ArnaudBarre
approved these changes
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These checks existed from the first implementation (vitejs/vite#10239), but I think these are not necessary.
This improved the window reload perf a bit. (on the other hand, using
import * as currentExports from 'id'instead ofRefreshRuntime.__hmr_import(import.meta.url)degraded the perf, so I'm leaving that as full-bundle mode only)