Skip to content

feat(rsc): enable buildApp plugin hook by default for Vite 7 #815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 1, 2025
Merged

feat(rsc): enable buildApp plugin hook by default for Vite 7 #815

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ec525eb
feat(rsc): enable `buildApp` plugin hook for Vite 7
hi-ogawa Sep 1, 2025
35561ad
chore: cleanup
hi-ogawa Sep 1, 2025
fbd1554
Merge branch 'main' into 09-01-feat_rsc_enable_buildapp_plugin_hook_f…
hi-ogawa Sep 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/plugin-rsc/examples/ssg/vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ function rscSsgPlugin(): Plugin[] {
return {
appType: env.isPreview ? 'mpa' : undefined,
rsc: {
useBuildAppHook: true,
serverHandler: env.isPreview ? false : undefined,
},
}
Expand Down
1 change: 0 additions & 1 deletion packages/plugin-rsc/examples/starter-cf-single/vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ export default defineConfig({
},
serverHandler: false,
loadModuleDevProxy: true,
useBuildAppHook: true,
}),
cloudflare({
configPath: './wrangler.jsonc',
Expand Down
7 changes: 6 additions & 1 deletion packages/plugin-rsc/src/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ export type RscPluginOptions = {
/**
* use `Plugin.buildApp` hook (introduced on Vite 7) instead of `builder.buildApp` configuration
* for better composability with other plugins.
* @default false
* @default true since Vite 7
*/
useBuildAppHook?: boolean

Expand Down Expand Up @@ -428,6 +428,11 @@ export default function vitePluginRsc(
},
}
},
configResolved() {
if (Number(vite.version.split('.')[0]) >= 7) {
rscPluginOptions.useBuildAppHook ??= true
}
},
buildApp: {
async handler(builder) {
if (rscPluginOptions.useBuildAppHook) {
Expand Down
Loading