fix(rsc): fix cjs transform to preserve module.exports on require side and allow exports assignment + expose cjsModuleRunnerPlugin
#833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
hi-ogawa
changed the title
cjsModuleRunnerPlugincjsModuleRunnerPlugin
hi-ogawa
changed the title
cjsModuleRunnerPluginmodule.exports on require side
hi-ogawa
changed the title
module.exports on require sidemodule.exports on require side
hi-ogawa
changed the title
module.exports on require sidemodule.exports on require side and allow exports assignment
hi-ogawa
changed the title
module.exports on require side and allow exports assignmentmodule.exports on require side and allow exports assignment + expose cjsModuleRunnerPlugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
summary
const exports = {}withlet exports = {}since reassignment ofexportsvariable is allowed. See https://nodejs.org/docs/v22.19.0/api/modules.html#exports-shortcutrequire("dep")into(await import("dep")).defaultto accessmodule.exportsobject directlydebugpackage which internally usesrequire("./common.js")()where./common.jsexports function. https://github.com/debug-js/debug/blob/33330fa8616b9b33f29f7674747be77266878ba6/src/node.js#L240cjsModuleRunnerPluginso it's easier to test against issues likessrLoadModule()errors when loading a commonjs npm package vite#20726