-
-
Notifications
You must be signed in to change notification settings - Fork 187
fix(rsc): keep server stylesheet link for hmr and avoid injecting css via client js #841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
hi-ogawa
merged 21 commits into
main
from
09-12-fix_rsc_keep_server_stylesheet_link_for_hmr
Sep 13, 2025
Merged
fix(rsc): keep server stylesheet link for hmr and avoid injecting css via client js #841
hi-ogawa
merged 21 commits into
main
from
09-12-fix_rsc_keep_server_stylesheet_link_for_hmr
Sep 13, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_environment' into 09-12-fix_rsc_keep_server_stylesheet_link_for_hmr
commit: |
Base automatically changed from
09-12-refactor_rsc_self-accept_rsc_css_module_on_client_environment
to
main
September 12, 2025 09:48
…mport_works_without_reload' into 09-13-test_rsc_test_adding_css_import_works_without_reload
…oad' into 09-12-fix_rsc_keep_server_stylesheet_link_for_hmr
…heet_link_for_hmr' into 09-12-fix_rsc_keep_server_stylesheet_link_for_hmr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
<link>
and client inline<style>
#677As we've seen in #776, Vite can actually handle css hmr by replacing
<link rel="stylesheet" ... />
https://github.com/vitejs/vite/blob/84079a84ad94de4c1ef4f1bdb2ab448ff2c01196/packages/vite/src/client/client.ts#L200-L201. We've been adding separateimport ".../xxx.css"
via wrapper client jsimporter-resources?rsc-browser
virtual for hmr, but that should be unnecessary.TODO
.module.css?direct
duringhotUpdate
. Also otherwise, it would cause full reload.<link>
and client inline<style>
#677