fix(rsc): fix plugin name in `client-only` error message #862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Sep 16, 2025

packages/plugin-rsc/e2e/validate-imports.test.ts

-Original file line number
+Diff line change
@@ Expand Up / @@ -102,8 +102,8 @@ @@
             throwOnError: false,
             nodeOptions: { cwd: root },
           })
           expect(result.stderr).toContain(
-            `'server-only' cannot be imported in client build`,
+            `[rsc:validate-imports] 'server-only' cannot be imported in client build`,
           )
           expect(result.exitCode).not.toBe(0)
         })
@@ Expand Down Expand Up / @@ -151,8 +151,8 @@ @@
             throwOnError: false,
             nodeOptions: { cwd: root },
           })
           expect(result.stderr).toContain(
-            `'client-only' cannot be imported in server build`,
+            `[rsc:validate-imports] 'client-only' cannot be imported in server build`,
           )
           expect(result.exitCode).not.toBe(0)
         })
@@ Expand Down @@

packages/plugin-rsc/src/plugin.ts

-Original file line number
+Diff line change
@@ Expand Up / @@ -1311,7 +1311,8 @@ function vitePluginUseClient( @@
             async handler(source, importer, options) {
               if (
                 this.environment.name === serverEnvironmentName &&
-                bareImportRE.test(source)
+                bareImportRE.test(source) &&
+                !(source === 'client-only' || source === 'server-only')
               ) {
                 const resolved = await this.resolve(source, importer, options)
                 if (resolved && resolved.id.includes('/node_modules/')) {
@@ Expand Down @@

Provide feedback