Skip to content

ci: harden workflow #878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 19, 2025
Merged

ci: harden workflow #878

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8b53341
ci: disable pnpm cache when publishing
sapphi-red Sep 19, 2025
fbd64c5
ci: pin yyx990803/release-tag
sapphi-red Sep 19, 2025
3e3af0c
ci: avoid interpolation
sapphi-red Sep 19, 2025
3d829e3
ci: disallow installation scripts before publish
sapphi-red Sep 19, 2025
aca257c
ci: fix use bash on windows
sapphi-red Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions .github/workflows/ci-rsc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,18 +65,26 @@ jobs:
- name: install react
if: ${{ matrix.react_version }}
run: |
sed -i "/^overrides:/a\ react: \"${{ matrix.react_version }}\"" pnpm-workspace.yaml
sed -i "/^overrides:/a\ react-dom: \"${{ matrix.react_version }}\"" pnpm-workspace.yaml
sed -i "/^overrides:/a\ react-server-dom-webpack: \"${{ matrix.react_version }}\"" pnpm-workspace.yaml
sed -i "/^overrides:/a\ react: \"$REACT_VERSION\"" pnpm-workspace.yaml
sed -i "/^overrides:/a\ react-dom: \"$REACT_VERSION\"" pnpm-workspace.yaml
sed -i "/^overrides:/a\ react-server-dom-webpack: \"$REACT_VERSION\"" pnpm-workspace.yaml
pnpm i --no-frozen-lockfile
env:
REACT_VERSION: ${{ matrix.react_version }}
- run: pnpm build
- name: install rolldown
if: ${{ matrix.rolldown }}
run: |
sed -i '/^overrides:/a\ vite: "npm:rolldown-vite@latest"' pnpm-workspace.yaml
pnpm i --no-frozen-lockfile
- run: pnpm -C packages/plugin-rsc exec playwright install ${{ matrix.browser }}
- run: pnpm -C packages/plugin-rsc test-e2e-ci --project=${{ matrix.browser }}
- run: pnpm -C packages/plugin-rsc exec playwright install "$BROWSER_NAME"
shell: bash
env:
BROWSER_NAME: ${{ matrix.browser }}
- run: pnpm -C packages/plugin-rsc test-e2e-ci --project="$BROWSER_NAME"
shell: bash
env:
BROWSER_NAME: ${{ matrix.browser }}
- uses: actions/upload-artifact@v4
if: always()
with:
Expand Down
7 changes: 6 additions & 1 deletion .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,11 @@ jobs:
with:
node-version: 22
registry-url: https://registry.npmjs.org/
# disable cache, to avoid cache poisoning (https://docs.zizmor.sh/audits/#cache-poisoning)
package-manager-cache: false

- name: Disallow installation scripts
run: yq '.onlyBuiltDependencies = []' -i pnpm-workspace.yaml

- name: Install deps
run: pnpm install
Expand Down Expand Up @@ -59,7 +64,7 @@ jobs:
tag-name: ${{ github.ref_name }}

- if: steps.tag.outputs.isAlpha == 'false' && steps.tag.outputs.pkgName == 'plugin-rsc'
uses: yyx990803/release-tag@master
uses: yyx990803/release-tag@8cccf7c5aa332d71d222df46677f70f77a8d2dc0 # v1.0.0
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/release-continuous.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,11 @@ jobs:
- uses: actions/setup-node@v5
with:
node-version: lts/*
# disable cache, to avoid cache poisoning (https://docs.zizmor.sh/audits/#cache-poisoning)
package-manager-cache: false

- name: Disallow installation scripts
run: yq '.onlyBuiltDependencies = []' -i pnpm-workspace.yaml

- name: Install dependencies
run: pnpm install
Expand Down
Loading