perf(react): use native refresh wrapper plugin in rolldown-vite #881
+362
−481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The perf gain comes from the fact that you skip round-trip for all JSX? files? |
|
I believe so (I didn't dig down much though). The other potential reason I can think of is since all files that is processed by JS would be processed serially, even if each process doesn't take that much time, it can be slower than other transforms done on the native side. It also mean that there might be a long queue which would be bad for mutex. |
hi-ogawa
approved these changes
Sep 25, 2025
1 task
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Sep 28, 2025
| datasource | package | from | to | | ---------- | -------------------- | ----- | ----- | | npm | @vitejs/plugin-react | 5.0.3 | 5.0.4 | ## [v5.0.4](https://github.com/vitejs/vite-plugin-react/blob/HEAD/packages/plugin-react/CHANGELOG.md#504-2025-09-27) ##### Perf: use native refresh wrapper plugin in rolldown-vite ([#881](vitejs/vite-plugin-react#881))
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Sep 28, 2025
| datasource | package | from | to | | ---------- | -------------------- | ----- | ----- | | npm | @vitejs/plugin-react | 5.0.3 | 5.0.4 | ## [v5.0.4](https://github.com/vitejs/vite-plugin-react/blob/HEAD/packages/plugin-react/CHANGELOG.md#504-2025-09-27) ##### Perf: use native refresh wrapper plugin in rolldown-vite ([#881](vitejs/vite-plugin-react#881))
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds some code to use native refresh wrapper plugin in rolldown-vite.