-
-
Notifications
You must be signed in to change notification settings - Fork 187
ci(rsc): add daily schedule to test canary/experimental React versions #897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(rsc): add daily schedule to test canary/experimental React versions #897
Conversation
Co-authored-by: hi-ogawa <[email protected]>
- os: ubuntu-latest | ||
browser: chromium | ||
react_version: canary | ||
- os: ubuntu-latest | ||
browser: chromium | ||
react_version: experimental |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot Would this runs all matrix? Is it possible to run only two canary/experimental modes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you're right! I've updated the workflow to run only canary/experimental modes on scheduled runs.
Changes in commit e4cd338:
- Added
if: github.event_name != 'schedule'
to the existingtest-e2e
job to skip it on scheduled runs - Added new
test-e2e-scheduled
job that only runs canary and experimental on ubuntu-latest with chromium when triggered by schedule
This optimizes CI resources while still achieving the goal of daily canary/experimental testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot The change is worse. Let's revert it and actually running whole thing is fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted in commit 07a67ae. The workflow now runs the full test matrix on scheduled runs, same as push/PR events.
Co-authored-by: hi-ogawa <[email protected]>
Co-authored-by: hi-ogawa <[email protected]>
Summary
Adds a daily scheduled run to the
ci-rsc
workflow to automatically test React canary and experimental versions every day at midnight UTC.Changes
Added a
schedule
trigger with a daily cron expression (0 0 * * *
) to.github/workflows/ci-rsc.yml
. This ensures continuous monitoring of plugin-rsc compatibility with React's latest development versions.Motivation
The workflow already includes canary and experimental React versions in the test matrix, but these were only tested on push/PR events. Running these tests daily helps catch compatibility issues early and provides better visibility into the stability of React's development versions.
Workflow Behavior
The
ci-rsc
workflow now runs on:All triggers run the full test matrix including:
Related to #630 which added support for testing React nightly versions.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.