Skip to content

chore(rsc): remove loader from react-router example for react 19.2 #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2025
Merged

chore(rsc): remove loader from react-router example for react 19.2 #910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions packages/plugin-rsc/e2e/react-router.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,6 @@ test.describe('build-cloudflare', () => {
})

function defineTest(f: Fixture) {
test('loader', async ({ page }) => {
await page.goto(f.url())
await expect(page.getByText(`loaderData: {"name":"Unknown"}`)).toBeVisible()
})

test('client', async ({ page }) => {
await page.goto(f.url('./about'))
await waitForHydration(page)
Expand Down
4 changes: 2 additions & 2 deletions packages/plugin-rsc/examples/react-router/app/root.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { TestClientState, TestHydrated } from './routes/client'
import { DumpError, GlobalNavigationLoadingBar } from './routes/root.client'

export function Layout({ children }: { children: React.ReactNode }) {
console.log('Layout')
console.log('[debug] root - Layout')
return (
<html lang="en">
<head>
Expand Down Expand Up @@ -41,7 +41,7 @@ export function Layout({ children }: { children: React.ReactNode }) {
}

export default function Component() {
console.log('Root')
console.log('[debug] root - Component')
return (
<>
<Outlet />
Expand Down
2 changes: 1 addition & 1 deletion packages/plugin-rsc/examples/react-router/app/routes/home.actions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@
export async function sayHello(defaultName: string, formData: FormData) {
await new Promise((resolve) => setTimeout(resolve, 500))
const name = formData.get('name') || defaultName
console.log(`Hello, ${name}`)
console.log(`[debug] sayHello - ${name}`)
}
20 changes: 3 additions & 17 deletions packages/plugin-rsc/examples/react-router/app/routes/home.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,33 +1,19 @@
namespace Route {
export type LoaderArgs = any
export type ComponentProps = any
}

import { sayHello } from './home.actions.ts'
import { PendingButton } from './home.client.tsx'
import './home.css'
import { TestActionStateServer } from './test-action-state/server.tsx'

export function loader({ request }: Route.LoaderArgs) {
const url = new URL(request.url)
const name = url.searchParams.get('name')
return { name: name || 'Unknown' }
}

const Component = ({ loaderData }: Route.ComponentProps) => {
const Component = () => {
return (
<main className="container my-8 px-8 mx-auto">
<article className="paper prose max-w-none">
<h1>Home</h1>
<p>This is the home page.</p>
<span className="test-style-home">[test-style-home]</span>
<pre>
<code>loaderData: {JSON.stringify(loaderData)}</code>
</pre>
<h2>Server Action</h2>
<form
className="no-prose grid gap-6"
action={sayHello.bind(null, loaderData.name)}
action={sayHello.bind(null, 'Demo')}
>
<div className="grid gap-1">
<label className="label" htmlFor="name">
Expand All @@ -38,7 +24,7 @@ const Component = ({ loaderData }: Route.ComponentProps) => {
id="name"
type="text"
name="name"
placeholder={loaderData.name}
placeholder={'Demo'}
/>
</div>
<div>
Expand Down
Loading