Skip to content

fix(react-swc): remove __filename and __dirname checks #920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 14, 2025
Merged

fix(react-swc): remove __filename and __dirname checks #920

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
585d6c9
Initial plan
Copilot Oct 14, 2025
08382e5
Remove __filename and __dirname checks from plugin-react-swc
Copilot Oct 14, 2025
941e090
Use import.meta.dirname instead of computing _dirname manually
Copilot Oct 14, 2025
793bccc
chore: update comment
sapphi-red Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions packages/plugin-react-swc/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,15 +21,8 @@
import * as vite from 'vite'
import { exactRegex } from '@rolldown/pluginutils'

/* eslint-disable no-restricted-globals */
const _dirname =
typeof __dirname !== 'undefined'
? __dirname
: dirname(fileURLToPath(import.meta.url))
const resolve = createRequire(
typeof __filename !== 'undefined' ? __filename : import.meta.url,
).resolve
/* eslint-enable no-restricted-globals */
const _dirname = dirname(fileURLToPath(import.meta.url))
const resolve = createRequire(import.meta.url).resolve

type Options = {
/**
Expand Down Expand Up @@ -112,7 +105,7 @@
load: {
filter: { id: exactRegex(runtimePublicPath) },
handler: (id) =>
id === runtimePublicPath

Check failure on line 108 in packages/plugin-react-swc/src/index.ts

View workflow job for this annotation

GitHub Actions / copilot 

The 'import.meta.dirname' is still an experimental feature and is not supported until Node.js 22.16.0 (backported: ^21.2.0, ^20.11.0). The configured version range is '^20.19.0 || >=22.12.0'
? readFileSync(
join(_dirname, 'refresh-runtime.js'),
'utf-8',
Expand Down
Loading