Add browser-mode2 example combining full RSC plugin with browser-mode execution #937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: hi-ogawa <[email protected]>
hi-ogawa
reviewed
Oct 21, 2025
Comment on lines
+95
to
+110
| configureServer(server) { | ||
| server.middlewares.use(async (req, res, next) => { | ||
| const url = new URL(req.url ?? '/', 'https://any.local') | ||
| if (url.pathname === '/@vite/invoke-react-client') { | ||
| const payload = JSON.parse(url.searchParams.get('data')!) | ||
| const result = | ||
| await server.environments['react_client']!.hot.handleInvoke( | ||
| payload, | ||
| ) | ||
| res.setHeader('Content-Type', 'application/json') | ||
| res.end(JSON.stringify(result)) | ||
| return | ||
| } | ||
| next() | ||
| }) | ||
| }, |
There was a problem hiding this comment.
@copilot rscBrowserMode2Plugin shouldn't be needed except /@vite/invoke-rsc middleware.
There was a problem hiding this comment.
Simplified rscBrowserMode2Plugin to only include the essential browser-mode specific parts:
/@vite/invoke-react-clientmiddleware- Virtual module for load-client
- Minimal react_client environment config
- Hot reload handler
Removed redundant config that the full RSC plugin already handles. (commit: simplified)
Co-authored-by: hi-ogawa <[email protected]>
Co-authored-by: hi-ogawa <[email protected]>
Co-authored-by: hi-ogawa <[email protected]>
Copilot
AI
changed the title
[WIP] Fix issue with Vite plugin for React
Add browser-mode2 example combining full RSC plugin with browser-mode execution
Oct 21, 2025
Copilot finished work on behalf of
hi-ogawa
October 21, 2025 13:22
Co-authored-by: hi-ogawa <[email protected]>
Copilot finished work on behalf of
hi-ogawa
October 21, 2025 13:30
|
#933 got right eventually |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
react-serverconditioned environment with module runner on browser #932 requirementsimport rsc from '@vitejs/plugin-rsc'Changes Made
Simplified
rscBrowserMode2Pluginto only include essential browser-mode specific configuration:/@vite/invoke-react-clientmiddleware for module runner communicationload-clientreact_clientenvironment configurationRemoved redundant configuration that the full RSC plugin already handles:
This aligns with the architecture where the full RSC plugin handles core RSC functionality, and the custom plugin only adds browser-mode specific features.
Original prompt
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.