Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Oct 22, 2025

Removes the redundant examples/ssg test block from packages/plugin-rsc/e2e/isolated.test.ts (lines 64-93).

Background

The isolated test file contained a test block for the SSG example that duplicated functionality already covered by the dedicated packages/plugin-rsc/e2e/ssg.test.ts file.

Changes

  • Removed the test.describe('examples/ssg', ...) block that was testing the SSG example in an isolated fixture setup
  • This removes 2 test cases from isolated.test.ts (down from 58 to 56 total tests)
  • The dedicated ssg.test.ts continues to provide comprehensive coverage for the SSG example with proper test setup

Verification

  • All remaining tests in isolated.test.ts pass successfully (50 passed, 6 skipped)
  • The dedicated ssg.test.ts continues to work correctly (2 tests passed)
  • No functional changes to the codebase - purely test cleanup

This cleanup reduces test redundancy while maintaining full test coverage through the dedicated test file.

Original prompt

remove

test.describe('examples/ssg', () => {
const tmpRoot = path.join(
process.env['RUNNER_TEMP'] || os.tmpdir(),
'test-vite-rsc-ssg',
)
test.beforeAll(async () => {
await setupIsolatedFixture({
src: 'examples/ssg',
dest: tmpRoot,
})
})
test.describe('dev', () => {
const f = useFixture({ root: tmpRoot, mode: 'dev' })
test('basic', async ({ page }) => {
await page.goto(f.url())
await waitForHydration(page)
})
})
test.describe('build', () => {
const f = useFixture({ root: tmpRoot, mode: 'build' })
test('basic', async ({ page }) => {
await page.goto(f.url())
await waitForHydration(page)
})
})
})


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Remove isolated test case from plugin-rsc Remove redundant SSG test from isolated.test.ts Oct 22, 2025
Copilot AI requested a review from hi-ogawa October 22, 2025 11:35
Copilot finished work on behalf of hi-ogawa October 22, 2025 11:35
@hi-ogawa hi-ogawa changed the title Remove redundant SSG test from isolated.test.ts chore(rsc): remove redundant SSG test from isolated.test.ts Oct 22, 2025
@hi-ogawa hi-ogawa marked this pull request as ready for review October 22, 2025 11:42
@hi-ogawa hi-ogawa merged commit 202ed19 into main Oct 23, 2025
37 of 52 checks passed
@hi-ogawa hi-ogawa deleted the copilot/remove-isolated-test-case branch October 23, 2025 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants