Skip to content

chore: add type: module to playgrounds #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

chore: add type: module to playgrounds #273

wants to merge 1 commit into from

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Oct 17, 2023

Description

vitejs/vite#14660 is needed.

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@yyx990803
Copy link
Member

yyx990803 commented Nov 11, 2024

Superseded by #466

@yyx990803 yyx990803 closed this Nov 11, 2024
@sapphi-red sapphi-red deleted the chore/use-esm-vite branch October 6, 2025 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

p1-chore 🧹

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sapphi-red @yyx990803