Skip to content

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Oct 14, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
serve-static 1.15.0 -> 1.16.0 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2024-43800

Impact

passing untrusted user input - even after sanitizing it - to redirect() may execute untrusted code

Patches

this issue is patched in serve-static 1.16.0

Workarounds

users are encouraged to upgrade to the patched version of express, but otherwise can workaround this issue by making sure any untrusted inputs are safe, ideally by validating them against an explicit allowlist

Details

successful exploitation of this vector requires the following:

  1. The attacker MUST control the input to response.redirect()
  2. express MUST NOT redirect before the template appears
  3. the browser MUST NOT complete redirection before:
  4. the user MUST click on the link in the template

Release Notes

expressjs/serve-static (serve-static)

v1.16.0

Compare Source

===================

  • Remove link renderization in html while redirecting

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 14, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@vitejs/plugin-vue@459
pnpm add https://pkg.pr.new/@vitejs/plugin-vue-jsx@459

commit: 32cc67c

@renovate
Copy link
Contributor Author

renovate bot commented Oct 30, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@edison1105 edison1105 merged commit 2942f7e into main Oct 30, 2024
9 checks passed
@edison1105 edison1105 deleted the renovate/npm-serve-static-vulnerability branch October 30, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants