feat(vue)!: separate include and exclude from api.options and add filter

[sapphi-red]

Description

Adds filter to plugin-vue so that it makes the plugin performant when used in rolldown-vite.

Additional context

---

What is the purpose of this pull request?

• Bug fix
• New Feature
• Documentation update
• Other

Before submitting the PR, please make sure you do the following

• Read the Contributing Guidelines.
• Read the Pull Request Guidelines and follow the PR Title Convention.
• Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
• Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
• Ideally, include relevant tests that fail without this PR but pass with it.

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/@vitejs/plugin-vue@582

npm i https://pkg.pr.new/@vitejs/plugin-vue-jsx@582

commit: 962d845

[sapphi-red]

To have this part of change, we need to introduce a breaking change.
The filter has to have a same value after configResolved hook is called (because the value is passed to rolldown and cannot be modified), but currently options.value.include / options.value.exclude can be changed in any time.

I can revert this part for now so we can merge the other parts and make a separate PR if that's better.

[TheAlexLichter]

The same applies to other cases where options.include/.exclude exists (e.g. in https://github.com/TheAlexLichter/unplugin-auto-import/blob/9c06cb618ca5fcabfe4ec1729e24eea2d87a48be/src/core/unplugin.ts#L20-L22)?

[sapphi-red]

I think it doesn't apply to those cases.
In this plugin-vue's case, options.value is exposed via api, which is meant to be used to update the option.value. So I think the contract here is that setting api.options will update the option.
On the other hand, in that unplugin-auto-import case, I think people won't expect options.include to be modified after the plugin is instantiated. For example, the code below would do that, but I guess people won't expect this to work unless explicitly documented.

const options = { include: [] }
setTimeout(() => {
  options.include.push('something') // or options.include = ['something-else']
}, 1000)
const plugin = autoImport(options)

[sapphi-red]

@sxzz What are your thoughts on this? (since you introduced this feature)

[sxzz]

Vue Macros is using this API to modify some options like template.compilerOptions.

Can we make api.include/exclude as a getter/setter, linking to transform.filter?

[sapphi-red]

Can we make api.include/exclude as a getter/setter, linking to transform.filter?

Do you mean something like below?

let filter = {}
const p = {
  api: { get include() { return filter.include }, set include(v){ filter.include = v } },
  transform: { filter, handler() { /* omit */ } }
}

Is it to make it clear that include/exclude cannot be updated after configResolved hook is called?

[sxzz]

Yes, we can add a jsdoc

[sapphi-red]

@sxzz I've updated the PR 👍

[sapphi-red]

@sxzz @haoqunjiang @edison1105 Do you have any thoughts on the next major release?

[edison1105]

LGTM~

[sxzz]

I prefer to release a beta major version.

[sapphi-red]

OK. I'll merge this and cut a beta.