perf(worker): rebuild only when affected #20559
Open
+223
−127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
added
p2-nice-to-have
|
/ecosystem-ci run |
commit: |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
|
📝 Ran ecosystem CI on
✅ astro, quasar, ladle, analogjs, histoire, qwik, sveltekit, rakkas, one, marko, react-router, nuxt, storybook, vite-setup-catalogue, vite-plugin-react, vite-plugin-svelte, vite-plugin-vue, vite-plugin-rsc, vitepress, vitest, vite-plugin-pwa, vuepress, vite-plugin-cloudflare, unocss, waku |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of building the worker every time any file is changed (before this PR
shouldTransformCachedModulereturns true), this PR makes the worker plugin to track the watched files so that the worker is re-built only when the content is changed.This PR was initiated by the fact that the usage of
shouldTransformCachedModulemakes it difficult to make the plugins performant (rolldown/rolldown#4389).refs #11919, #14712