Skip to content

fix: handle proxy.rewrite: () => '' #20679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: handle proxy.rewrite: () => '' #20679

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions packages/vite/src/node/server/middlewares/proxy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,20 @@ export function proxyMiddleware(
debug?.(`${req.url} -> ${opts.target || opts.forward}`)
if (opts.rewrite) {
req.url = opts.rewrite(req.url!)
// some users set `''` to req.url
// this was supported by http-proxy, but is not supported by http-proxy-3
const target = opts.target
if (
(req.url === '' || req.url.startsWith('?')) &&
target &&
opts.prependPath !== false
) {
const normalizedTarget =
typeof target === 'string' ? new URL(target) : target
req.url =
'pathname' in normalizedTarget ? normalizedTarget.pathname : '/'
options.prependPath = false
}
}
proxy.web(req, res, options)
return
Expand Down
Loading