fix: update build log to include environment name #20987
Merged
+1
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
added
p2-nice-to-have
hi-ogawa
deleted the
10-23-fix_update_build_log_to_include_environment_name
branch
|
Oh, I had a test case which asserts the old log, so ecosystem CI failed because of this (vitejs/vite-plugin-react#947). I wonder if there are other frameworks hit by this change. |
|
It seems it only plugin-rsc was affected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes build logs:
For
@vitejs/plugin-rsc, I've already added extra logs like vitejs/vite-plugin-react#936, but I think it makes sense to change here directly:example