fix(module-runner): incorrect column with sourcemapInterceptor: "prepareStackTrace"#21562
Merged
sapphi-red merged 2 commits intomainfrom Feb 5, 2026
Conversation
sapphi-red
commented
Feb 5, 2026
Contributor
|
Oh, having test would be nice though. |
Copilot AI
added a commit
that referenced
this pull request
Feb 5, 2026
…kTrace Co-authored-by: sapphi-red <[email protected]>
Member
Author
|
It seems the repro works fine with Vite 8 beta. It has line 4 instead of 1 so the bug doesn't trigger. I'm not sure why but going to merge this PR without a test. |
sapphi-red
added
p3-minor-bug
sapphi-red
deleted the
fix/module-runner-incorrect-col-with-sourcemapinterceptor-prepare-stacktrace
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original code for this part is
https://github.com/evanw/node-source-map-support/blob/7b5b81eb14c9ee6c6537398262bf7dab8580621c/source-map-support.js#L386-L395
The code was changed assuming that
noHeader.test(globalProcessVersion())always returns false. But the correct assumption here is that it always returns true.fixes #21561