-
Notifications
You must be signed in to change notification settings - Fork 2.3k
ci: dont install etcd twice in unit tests
#19068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
ci: dont install etcd twice in unit tests
#19068
Conversation
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19068 +/- ##
==========================================
- Coverage 69.90% 69.90% -0.01%
==========================================
Files 1612 1612
Lines 215796 215796
==========================================
- Hits 150858 150853 -5
- Misses 64938 64943 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
|
This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:
If no action is taken within 7 days, this PR will be closed. |
Description
This PR updates CI workflows that download
etcd, but also runmake tools.make toolsdownloadsetcdtodist/and force hard-links the binaries tobin/etcd*. This paves over the work we did in the workflows thatcurl'd the same binary to the same place. For workflows installingetcdviaapt-get, it's probably not being used, unless it's first in$PATH. After this PR we should just have 1 x version ofetcd✅Related Issue(s)
Checklist
Deployment Notes
AI Disclosure