-
Notifications
You must be signed in to change notification settings - Fork 2.3k
e2e tests: use t.Context() from testing as context.Context
#19081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e tests: use t.Context() from testing as context.Context
#19081
Conversation
Signed-off-by: Tim Vaillancourt <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
e2e tests: use t.Context() for contexte2e tests: use t.Context() from testing as context.Context
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19081 +/- ##
==========================================
- Coverage 69.90% 69.89% -0.02%
==========================================
Files 1612 1612
Lines 215817 215817
==========================================
- Hits 150865 150841 -24
- Misses 64952 64976 +24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Tim Vaillancourt <[email protected]>
|
Nice! I was initially concerned about this change introducing backporting pains, but |
Description
This PR moves instances of
context.Background()->t.Context()in e2e testsThis is a built-in context from the
testingpackage that lets cancellations ofgo test(CTRL+C) to propagate down to testsRelated Issue(s)
Checklist
Deployment Notes
AI Disclosure