Skip to content

Conversation

@timvaillancourt
Copy link
Contributor

@timvaillancourt timvaillancourt commented Dec 24, 2025

Description

This PR moves instances of context.Background() -> t.Context() in e2e tests

This is a built-in context from the testing package that lets cancellations of go test (CTRL+C) to propagate down to tests

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

AI Disclosure

@timvaillancourt timvaillancourt marked this pull request as ready for review December 24, 2025 00:03
@github-actions github-actions bot added this to the v24.0.0 milestone Dec 24, 2025
@timvaillancourt timvaillancourt self-assigned this Dec 24, 2025
@vitess-bot vitess-bot bot added NeedsWebsiteDocsUpdate What it says NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Dec 24, 2025
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Dec 24, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@timvaillancourt timvaillancourt removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Dec 24, 2025
@timvaillancourt timvaillancourt changed the title e2e tests: use t.Context() for context e2e tests: use t.Context() from testing as context.Context Dec 24, 2025
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
@timvaillancourt timvaillancourt enabled auto-merge (squash) December 24, 2025 00:34
Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>
@codecov
Copy link

codecov bot commented Dec 24, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 69.89%. Comparing base (7a3acd5) to head (89624be).
⚠️ Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
go/test/stress/utils.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19081      +/-   ##
==========================================
- Coverage   69.90%   69.89%   -0.02%     
==========================================
  Files        1612     1612              
  Lines      215817   215817              
==========================================
- Hits       150865   150841      -24     
- Misses      64952    64976      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arthurschreiber
Copy link
Member

arthurschreiber commented Jan 8, 2026

Nice! I was initially concerned about this change introducing backporting pains, but t.Context was added in go 1.24, and given that Vitess 22.x (oldest supported release branch at the time of writing) requires at least 1.24.10, I'm all in favor of this change. 👍

@timvaillancourt timvaillancourt merged commit 12126f1 into vitessio:main Jan 8, 2026
103 of 105 checks passed
@timvaillancourt timvaillancourt deleted the e2e-tests-t-Context branch January 8, 2026 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants