-
Notifications
You must be signed in to change notification settings - Fork 2.3k
go/vt/{mysqlctl,vttablet}: support restore tablet with CLONE #19084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: clone-from-donor
Are you sure you want to change the base?
Conversation
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## clone-from-donor #19084 +/- ##
====================================================
- Coverage 69.91% 69.89% -0.03%
====================================================
Files 1613 1613
Lines 216020 216111 +91
====================================================
+ Hits 151031 151050 +19
- Misses 64989 65061 +72 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
f6d8d1a to
3e96d27
Compare
3e96d27 to
628a0b4
Compare
Signed-off-by: Max Englander <[email protected]>
628a0b4 to
e7e2559
Compare
Signed-off-by: Max Englander <[email protected]>
Signed-off-by: Max Englander <[email protected]>
Signed-off-by: Max Englander <[email protected]>
Signed-off-by: Max Englander <[email protected]>
Signed-off-by: Max Englander <[email protected]>
Signed-off-by: Max Englander <[email protected]>
6ee25db to
cf1a804
Compare
| // and returns whether a restore action should be performed | ||
| func ShouldRestore(ctx context.Context, params RestoreParams) (bool, error) { | ||
| if params.DeleteBeforeRestore || RestoreWasInterrupted(params.Cnf) { | ||
| func ShouldRestore(ctx context.Context, logger logutil.Logger, cnf *Mycnf, mysqld MysqlDaemon, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these changes allow this to be called from both tabletmanager.restoreFromClone() and tabletmanager.RestoreBackup() without the former needing to construct RestoreParams, which is otherwise not needed by restoreFromClone().
Description
Next step after #19064. Adapted from @nickvanw code in private fork.
--restore-with-clone.--restore-with-cloneusestabletmanager.restoreFromClone().restoreFromClone()andRestoreBackup()use shared functions extracted fromRestoreBackup.Related Issue(s)
Checklist
Deployment Notes
AI Disclosure
AI was used.