Skip to content

Conversation

@maxenglander
Copy link
Collaborator

@maxenglander maxenglander commented Dec 24, 2025

Description

Next step after #19064. Adapted from @nickvanw code in private fork.

  • Add support to VTTablet for --restore-with-clone.
  • --restore-with-clone uses tabletmanager.restoreFromClone().
  • restoreFromClone() and RestoreBackup() use shared functions extracted from RestoreBackup.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

AI Disclosure

AI was used.

@github-actions github-actions bot added this to the v24.0.0 milestone Dec 24, 2025
@vitess-bot vitess-bot bot added NeedsWebsiteDocsUpdate What it says NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Dec 24, 2025
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Dec 24, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@maxenglander maxenglander added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Backup and Restore and removed NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Dec 25, 2025
@codecov
Copy link

codecov bot commented Dec 25, 2025

Codecov Report

❌ Patch coverage is 8.28402% with 155 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.89%. Comparing base (d40490b) to head (cf1a804).

Files with missing lines Patch % Lines
go/vt/vttablet/tabletmanager/restore.go 1.41% 139 Missing ⚠️
go/vt/vttablet/tabletmanager/tm_init.go 26.31% 14 Missing ⚠️
go/vt/mysqlctl/backup.go 85.71% 1 Missing ⚠️
go/vt/vttablet/tabletmanager/rpc_backup.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                  @@
##           clone-from-donor   #19084      +/-   ##
====================================================
- Coverage             69.91%   69.89%   -0.03%     
====================================================
  Files                  1613     1613              
  Lines                216020   216111      +91     
====================================================
+ Hits                 151031   151050      +19     
- Misses                64989    65061      +72     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@maxenglander maxenglander changed the base branch from clone-restore-refactor to clone-from-donor December 25, 2025 23:29
Signed-off-by: Max Englander <[email protected]>
Signed-off-by: Max Englander <[email protected]>
Signed-off-by: Max Englander <[email protected]>
// and returns whether a restore action should be performed
func ShouldRestore(ctx context.Context, params RestoreParams) (bool, error) {
if params.DeleteBeforeRestore || RestoreWasInterrupted(params.Cnf) {
func ShouldRestore(ctx context.Context, logger logutil.Logger, cnf *Mycnf, mysqld MysqlDaemon,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these changes allow this to be called from both tabletmanager.restoreFromClone() and tabletmanager.RestoreBackup() without the former needing to construct RestoreParams, which is otherwise not needed by restoreFromClone().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Backup and Restore NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says Type: Enhancement Logical improvement (somewhere between a bug and feature)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants