Skip to content

Conversation

@mhamza15
Copy link
Collaborator

Description

Adds support for views in MoveTables. Adds these flags for MoveTables create:

--all-views                                Copy all views from the source.
--exclude-views strings                    Source views to exclude from copying.
--skip-view-validation                     Skip validating that views reference tables being moved.
--views strings                            Source views to copy.

On creation, the views are created in the target keyspace, and routing rules for them are created (same as tables). SwitchTraffic works the same as tables. On MoveTables complete, views are dropped, renamed, or kept like tables, based on the --keep-data or --rename-tables flags.

Related Issue(s)

Closes #19131

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

AI Disclosure

Adds support for views in MoveTables. Adds these flags for `MoveTables
create`:

```
--all-views                                Copy all views from the source.
--exclude-views strings                    Source views to exclude from copying.
--skip-view-validation                     Skip validating that views reference tables being moved.
--views strings                            Source views to copy.
```

On creation, the views are created in the target keyspace, and routing
rules for them are created (same as tables). `SwitchTraffic` works the same
as tables. On `MoveTables complete`, views are dropped, renamed, or kept
like tables, based on the `--keep-data` or `--rename-tables` flags.

Closes vitessio#19131

Signed-off-by: Mohamed Hamza <[email protected]>
@mhamza15 mhamza15 self-assigned this Feb 12, 2026
@github-actions github-actions bot added the Component: VTAdmin VTadmin interface label Feb 12, 2026
@github-actions github-actions bot added this to the v24.0.0 milestone Feb 12, 2026
@vitess-bot vitess-bot bot added NeedsWebsiteDocsUpdate What it says NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Feb 12, 2026
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Feb 12, 2026

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: VTAdmin VTadmin interface NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: Support views in MoveTables

1 participant