docs: Add changelog entries for MySQL CLONE support and restore hook backup engine variable#19436
docs: Add changelog entries for MySQL CLONE support and restore hook backup engine variable#19436promptless[bot] wants to merge 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
(Line 195)
Citation: PR #19084 adds --restore-with-clone flag to VTTablet and VTBackup. Changes in go/cmd/vtbackup/cli/vtbackup.go and go/vt/vttablet/tabletmanager/restore.go.
View source
There was a problem hiding this comment.
(Line 195)
Citation: PR #19062 adds core MySQL CLONE infrastructure - CloneExecutor in go/vt/mysqlctl/clone.go, clone user flags (--db-clone-user, --db-clone-password, --db-clone-use-ssl), and --mysql-clone-enabled flag.
View source
There was a problem hiding this comment.
(Line 195)
Citation: PR #19064 adds CloneFromDonor at the topology level with --clone-from-primary and --clone-from-tablet flags in go/vt/mysqlctl/clone.go.
View source
|
|
||
| **Note:** All tablets participating in CLONE operations (both donors and recipients) must have `--mysql-clone-enabled` set during MySQL initialization to ensure the CLONE plugin is loaded and the clone user exists. | ||
|
|
||
| #### <a id="restore-hook-backup-engine-env"/>New `TM_RESTORE_DATA_BACKUP_ENGINE` Environment Variable for Restore Hook</a> |
There was a problem hiding this comment.
Citation: Based on PR #19405 which adds TM_RESTORE_DATA_BACKUP_ENGINE environment variable to the vttablet_restore_done hook. The implementation in go/vt/vttablet/tabletmanager/restore.go shows the value is sourced from backupManifest.BackupMethod and is only set when backupEngine != "".
View source
|
🔧 I noticed that some CI checks failed for this PR. I'm investigating whether the failures are caused by this suggestion. If they're unrelated or pre-existing, I'll leave this suggestion unchanged and create a separate suggestion if a standalone docs fix is needed. |
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
|
Promptless escalated the following message to you. If you respond, please remember to tag Promptless: I investigated the CI failure on the changelog PR for MySQL CLONE support and restore hook backup engine variable. Finding: This failure is not caused by the documentation content — it's a repository policy check requiring specific PR labels. The "Check Pull Request labels" workflow requires:
To resolve this, someone with repository access would need to add a |
Open this suggestion in Promptless to view citations and reasoning process
Documents two Backup and Restore features for v24.0.0:
MySQL CLONE Support for Replica Provisioning (PR mysqlctl,vttablet,vtbackup: support restore tablet and vtbackup restore phase with CLONE #19084): VTTablet and VTBackup now support using MySQL's native CLONE plugin to provision new replicas by copying data directly from a donor tablet over the network - a faster alternative to backup restore.
New
TM_RESTORE_DATA_BACKUP_ENGINEEnvironment Variable (PR Pass backup engine to vttablet_restore_done hook #19405): Thevttablet_restore_donehook now includes aTM_RESTORE_DATA_BACKUP_ENGINEenvironment variable containing the backup engine used for the restore, sourced from the backup manifest'sBackupMethodfield. This allows hook scripts to perform engine-specific actions.Trigger Events
vitessio/vitess PR #19084: mysqlctl,vttablet,vtbackup: support restore tablet and vtbackup restore phase with CLONE
Promptless Research (3 GitHub PRs)
Agent Response
vitessio/vitess PR #19405: Pass backup engine to vttablet_restore_done hook
Promptless Research (1 GitHub PR)
Agent Response
Tip: Create additional Docs Collections to keep multiple repositories in sync 📚