Skip to content

test: Add missing unit tests in vtgate/cli#19439

Open
Devanshusharma2005 wants to merge 6 commits intovitessio:mainfrom
Devanshusharma2005:test/vtgate-cli
Open

test: Add missing unit tests in vtgate/cli#19439
Devanshusharma2005 wants to merge 6 commits intovitessio:mainfrom
Devanshusharma2005:test/vtgate-cli

Conversation

@Devanshusharma2005
Copy link

@Devanshusharma2005 Devanshusharma2005 commented Feb 21, 2026

Description

This PR adds the missing unit tests for vtgate CLI (go/cmd/vtgate/cli)

Test command:

cd go/cmd/vtgate/cli
go test ./... -race -count=1 -coverprofile=coverage.out -covermode=atomic

Result:
Screenshot 2026-02-22 at 1 28 47 PM

Related Issue(s)

Fixes part of #14931

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

@github-actions github-actions bot added this to the v24.0.0 milestone Feb 21, 2026
@vitess-bot vitess-bot bot added NeedsWebsiteDocsUpdate What it says NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Feb 21, 2026
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Feb 21, 2026

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

Comment on lines 53 to 57
// testTopoOpener and testRunDefault are set by tests to inject a topo
// and skip servenv.RunDefault. Must be nil in production. Tests that set
// these must not call t.Parallel().
testTopoOpener func() *topo.Server
testRunDefault func()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should avoid adding test specific things to the production code if at all possible.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rolled back the cli changes. Will remember this for future test additions. ^^

@mattlord mattlord added Component: Build/CI Type: Testing and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Feb 22, 2026
@Devanshusharma2005
Copy link
Author

@mattlord ^^

@codecov
Copy link

codecov bot commented Feb 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.40%. Comparing base (70c7a72) to head (a6092bb).
⚠️ Report is 37 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (70c7a72) and HEAD (a6092bb). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (70c7a72) HEAD (a6092bb)
1 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main   #19439       +/-   ##
===========================================
- Coverage   69.67%   57.40%   -12.27%     
===========================================
  Files        1614       17     -1597     
  Lines      216793      439   -216354     
===========================================
- Hits       151044      252   -150792     
+ Misses      65749      187    -65562     
Flag Coverage Δ
partial 57.40% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Devanshu Sharma <devanshusharma658@gmail.com>
Signed-off-by: Devanshu Sharma <devanshusharma658@gmail.com>
Signed-off-by: Devanshu Sharma <devanshusharma658@gmail.com>
Signed-off-by: Devanshu Sharma <devanshusharma658@gmail.com>
Copy link
Member

@mattlord mattlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please see my note about using ErrorContains in a consistent way in these new tests. Please address that while we wait for the second reviewer. Thanks, @Devanshusharma2005 !

Signed-off-by: Devanshu Sharma <devanshusharma658@gmail.com>
@timvaillancourt timvaillancourt enabled auto-merge (squash) February 27, 2026 14:46
Signed-off-by: Devanshu Sharma <devanshusharma658@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants