fix(vtexplain): case-sensitive COMMENT check for sequence tables#19444
Open
anujagrawal380 wants to merge 1 commit intovitessio:mainfrom
Open
fix(vtexplain): case-sensitive COMMENT check for sequence tables#19444anujagrawal380 wants to merge 1 commit intovitessio:mainfrom
anujagrawal380 wants to merge 1 commit intovitessio:mainfrom
Conversation
Signed-off-by: Anuj Agrawal <anujagrawal380@gmail.com>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19444 +/- ##
==========================================
- Coverage 69.67% 69.65% -0.02%
==========================================
Files 1614 1614
Lines 216793 216819 +26
==========================================
- Hits 151044 151030 -14
- Misses 65749 65789 +40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
PTAL @mattlord |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug where vtexplain fails to recognize
vitess_sequencetables when the DDL uses uppercaseCOMMENT(e.g.,COMMENT 'vitess_sequence').The AST parser preserves the original casing of table options, but the check in vtexplain used a case-sensitive comparison (
option.Name == "comment"). Changed tostrings.EqualFoldso any casing works.Changes
strings.EqualFoldfor the comment option name check invtexplain_vttablet.goCOMMENTto verify the fixRelated Issue(s)
Fixes #14941
Checklist
Deployment Notes
AI Disclosure
Tests written by Claude.