Skip to content

fix(vtexplain): case-sensitive COMMENT check for sequence tables#19444

Open
anujagrawal380 wants to merge 1 commit intovitessio:mainfrom
anujagrawal380:fix-vtexplain-case-comment-check
Open

fix(vtexplain): case-sensitive COMMENT check for sequence tables#19444
anujagrawal380 wants to merge 1 commit intovitessio:mainfrom
anujagrawal380:fix-vtexplain-case-comment-check

Conversation

@anujagrawal380
Copy link
Contributor

@anujagrawal380 anujagrawal380 commented Feb 22, 2026

Description

Fixes a bug where vtexplain fails to recognize vitess_sequence tables when the DDL uses uppercase COMMENT (e.g., COMMENT 'vitess_sequence').

The AST parser preserves the original casing of table options, but the check in vtexplain used a case-sensitive comparison (option.Name == "comment"). Changed to strings.EqualFold so any casing works.

Changes

  • Use strings.EqualFold for the comment option name check in vtexplain_vttablet.go
  • Added a test case with uppercase COMMENT to verify the fix

Related Issue(s)

Fixes #14941

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

AI Disclosure

Tests written by Claude.

Signed-off-by: Anuj Agrawal <anujagrawal380@gmail.com>
@github-actions github-actions bot added this to the v24.0.0 milestone Feb 22, 2026
@vitess-bot vitess-bot bot added NeedsWebsiteDocsUpdate What it says NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Feb 22, 2026
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Feb 22, 2026

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@codecov
Copy link

codecov bot commented Feb 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.65%. Comparing base (70c7a72) to head (eccb465).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19444      +/-   ##
==========================================
- Coverage   69.67%   69.65%   -0.02%     
==========================================
  Files        1614     1614              
  Lines      216793   216819      +26     
==========================================
- Hits       151044   151030      -14     
- Misses      65749    65789      +40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@anujagrawal380
Copy link
Contributor Author

PTAL @mattlord

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug Report: vtexplain with sequence does not work when the vitess_sequence is used with uppercase COMMENT

1 participant