fix(snapshot): show focused diff for toMatchProperties mismatches#10009
Open
guoyangzhen wants to merge 1 commit intovitest-dev:mainfrom
Open
fix(snapshot): show focused diff for toMatchProperties mismatches#10009guoyangzhen wants to merge 1 commit intovitest-dev:mainfrom
guoyangzhen wants to merge 1 commit intovitest-dev:mainfrom
Conversation
…atches When toMatchSnapshot(properties) fails due to a property mismatch, the diff previously showed the full received object with all keys as additions, making it hard to identify the actual mismatch. This change filters the actual value to only include keys present in the expected properties object, so the diff focuses on the values that actually differ.
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
sheremet-va
added
the
maybe automated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9985
When
toMatchSnapshot(properties)fails due to a property mismatch, the diff previously showed the full received object with all its keys as additions, making it hard to identify the actual mismatched values.For example, with
expect({ x: 'world', y: 10 }).toMatchSnapshot({ y: 5 }), the diff showed:This made
xlook like an error when it's actually irrelevant to the properties check.Fix: Filter the
actualvalue to only include keys present in the expectedpropertiesobject before returning the error. The diff now focuses on the values that actually differ: