chore: keep single root tsconfig.json to align pnpm typecheck and vscode typescript#10010
Draft
hi-ogawa wants to merge 4 commits intovitest-dev:mainfrom
Draft
chore: keep single root tsconfig.json to align pnpm typecheck and vscode typescript#10010hi-ogawa wants to merge 4 commits intovitest-dev:mainfrom
tsconfig.json to align pnpm typecheck and vscode typescript#10010hi-ogawa wants to merge 4 commits intovitest-dev:mainfrom
Conversation
…nsistent VSCode experience Make VSCode use the root tsconfig.json (previously tsconfig.check.json) for all files, so editor type-checking matches `pnpm typecheck` exactly. Per-package tsconfigs are kept as tsconfig.build.json for build tooling. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Root `pnpm typecheck` covers the full monorepo. Per-package scripts were never run in CI and some were already broken due to lib mismatches when following path aliases into other packages. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Collaborator
Author
|
Well, I guess this went too far. Practically, the types get extended only for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Vscode picks up nearest
tsconfig.jsonand it causes a discrepancy betweenpnpm typecheckfailure and what shows up as red squiggles on vscode due topackages/*/tsconfig.json. This PR renames roottsconfig.check.jsontotsconfig.jsonand rename all per-packagetsconfig.jsontotsconfig.build.json, so that Vscode always uses roottsconfig.jsonas a source of truth.This can technically hide the real typing issue, but per-package typecheck wasn't verified consistently (and some are currently broken), so personally ensuring just
pnpm typecheckis a good trade off and benefits enough from typescript. At times,pnpm typecheckfails while vscode shows no red squiggles and that's hard to understand.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.