docs: fix dependent example spelling#10017
Open
Rohan5commit wants to merge 1 commit intovitest-dev:mainfrom
Open
docs: fix dependent example spelling#10017Rohan5commit wants to merge 1 commit intovitest-dev:mainfrom
Rohan5commit wants to merge 1 commit intovitest-dev:mainfrom
Conversation
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
Fixes the spelling of the dependent fixture name in the test.extend / test.override documentation example.
Changes:
- Renames
dependant→dependentin thetest.overrideexample code and inline comment. - Updates the example’s destructured fixture parameter and expectation to use the corrected name.
Comment on lines
300
to
+304
|
|
||
| test('uses scoped value', ({ dependant }) => { | ||
| // `dependant` uses the new overridden value that is scoped | ||
| test('uses scoped value', ({ dependent }) => { | ||
| // `dependent` uses the new overridden value that is scoped | ||
| // to all tests in this suite | ||
| expect(dependant).toEqual({ dependency: 'new' }) | ||
| expect(dependent).toEqual({ dependency: 'new' }) |
There was a problem hiding this comment.
In this example, dependency is a string fixture ('default' / overridden to 'new') and dependent returns dependency directly, so dependent will be 'new' (a string). The current assertion expects an object { dependency: 'new' }, which doesn't match the shown fixtures. Either update the assertion to compare against 'new', or change the dependent fixture to return an object (and adjust the override accordingly).
sheremet-va
added
the
maybe automated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the spelling of
dependentin thetest.extenddocumentation example.Related issue
N/A. This is a trivial docs-only fix.
Guideline alignment
Validation/testing
Not run. This is a docs-only change.
AI assistance disclosure
Codex assisted with identifying and correcting this typo; the change was reviewed before submission.