feat(coverage): default to text reporter skipFull if agent detected#10018
Open
hi-ogawa wants to merge 4 commits intovitest-dev:mainfrom
Open
feat(coverage): default to text reporter skipFull if agent detected#10018hi-ogawa wants to merge 4 commits intovitest-dev:mainfrom
skipFull if agent detected#10018hi-ogawa wants to merge 4 commits intovitest-dev:mainfrom
Conversation
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
AriPerkkio
previously approved these changes
Mar 29, 2026
Member
AriPerkkio
left a comment
There was a problem hiding this comment.
Good idea but I wonder if it confuses agents or humans to see empty reports.
text reporter should probably print something like ... and 50 files with 100% coverage. 🤔
Collaborator
Author
We can also ensure |
sheremet-va
approved these changes
Mar 30, 2026
sheremet-va
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I was prototyping a new
text-agentcoverage reporter, which skips 100% coverage just like testagentreporter (#9779) skips passing tests. But then I noticedtextcoverage reporter already supportsskipFullwhich does mostly same.This PR auto enables
skipFullwhen the agent is detected.(EDIT: and also auto configure
text-summary, so it has aggregated stats to avoid ended up with empty output.)Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.