Skip to content

fix: add @vitest/coverage-v8 and @vitest/coverage-istanbul as optional dependency#10025

Merged
sheremet-va merged 1 commit intovitest-dev:mainfrom
alan-agius4:mising-deps
Mar 30, 2026
Merged

fix: add @vitest/coverage-v8 and @vitest/coverage-istanbul as optional dependency#10025
sheremet-va merged 1 commit intovitest-dev:mainfrom
alan-agius4:mising-deps

Conversation

@alan-agius4
Copy link
Copy Markdown
Contributor

@alan-agius4 alan-agius4 commented Mar 30, 2026

Description

The @vitest/coverage-v8 package is now listed as an optional peer dependency. This allows users to opt-in to v8 coverage without requiring it as a hard dependency, while satisfying package manager hoisting and linking requirements such as pnpm and Bazel.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.
  • Please check Allow edits by maintainers to make review process faster. Note that this option is not available for repositories that are owned by Github organizations.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@alan-agius4 alan-agius4 force-pushed the mising-deps branch 2 times, most recently from ebed9aa to 73b310a Compare March 30, 2026 08:25
@netlify
Copy link
Copy Markdown

netlify bot commented Mar 30, 2026

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit d538c78
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/69ca33611dfd94000897aca9
😎 Deploy Preview https://deploy-preview-10025--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 30, 2026

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 7b6d676
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/69ca6fcccdad4100081ae4f1
😎 Deploy Preview https://deploy-preview-10025--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

alan-agius4 added a commit to alan-agius4/angular-cli that referenced this pull request Mar 30, 2026
Fixes an issue where running Vitest tests with coverage in a strict pnpm/Bazel environment fails because @vitest/coverage-v8 cannot be found by the vitest execution.

See: vitest-dev/vitest#10025
alan-agius4 added a commit to angular/angular-cli that referenced this pull request Mar 30, 2026
Fixes an issue where running Vitest tests with coverage in a strict pnpm/Bazel environment fails because @vitest/coverage-v8 cannot be found by the vitest execution.

See: vitest-dev/vitest#10025
Copy link
Copy Markdown
Member

@sheremet-va sheremet-va left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also add @vitest/coverage-istanbul

…` as optional dependency

The `@vitest/coverage-v8` and `@vitest/coverage-istanbul` package is now listed as an optional peer dependency. This allows users to opt-in to v8 coverage without requiring it as a hard dependency, while satisfying package manager hoisting and linking requirements.
@alan-agius4
Copy link
Copy Markdown
Contributor Author

alan-agius4 commented Mar 30, 2026

@sheremet-va done. PTAL.

@alan-agius4 alan-agius4 changed the title fix: add @vitest/coverage-v8 as optional dependency fix: add @vitest/coverage-v8 and @vitest/coverage-istanbul as optional dependency Mar 30, 2026
@sheremet-va sheremet-va merged commit 146d4f0 into vitest-dev:main Mar 30, 2026
16 checks passed
@alan-agius4 alan-agius4 deleted the mising-deps branch March 30, 2026 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants