Skip to content

Conversation

@ThibautMarechal
Copy link
Contributor

@ThibautMarechal ThibautMarechal commented Jan 2, 2026

Description

Resolves #9371

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.
  • Please check Allow edits by maintainers to make review process faster. Note that this option is not available for repositories that are owned by Github organizations.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@AriPerkkio AriPerkkio changed the title fix(dev): fix null options in addEventHandler #9371 fix: handle null options in addEventHandler #9371 Jan 2, 2026
Copy link
Member

@AriPerkkio AriPerkkio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though passing null as options doesn't make sense, I think the patched behaviour should be same as in browsers. Which is not to crash.

@sheremet-va sheremet-va merged commit 40841ff into vitest-dev:main Jan 4, 2026
15 of 16 checks passed
@ThibautMarechal ThibautMarechal deleted the bugfix/issue-9371-addEventListener-null-options branch January 4, 2026 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read properties of null (reading 'signal')

3 participants