Draft
Conversation
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
hi-ogawa
added a commit
to hi-ogawa/ivya
that referenced
this pull request
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
toMatchAriaSnapshot()andtoMatchAriaInlineSnapshot()matchers for asserting DOM accessibility trees, inspired by Playwright's aria snapshot feature.Under the hood, this introduces domain snapshot concept — a generic extension point that lets snapshot matchers delegate comparison to a semantic pipeline (
capture → parse → match → render) instead of string===. This architecture allows:polllike retry mechanism, which is important for aria snapshot on browser mode withexpect.element.ARIA is the first shipped adapter. The custom domain adapter API is left as experimental and documented like so.
Quick explaner
Snapshots support hand-edited regex patterns (
/pattern/) that survive--update:Questions
Follow-up considered
toMatchFileSnapshotTODO
expect.element + aria snapshotbecomes a special casedefineHelper. should be fixed on next playwright update, which has better async stack.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.