fix(types): bench.reporters no longer gives type errors when passing file name string paths#9695
Merged
hi-ogawa merged 1 commit intovitest-dev:mainfrom Feb 19, 2026
Merged
Conversation
hi-ogawa
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a oneline typing error inside
vitest/nodethat caused TypeScript to produce type errors complain aboutbench.reportersnot accepting arbitrary strings for reporter file paths. Vitest processes them just fine, but the type was overly restrictive and led to type errors that contradicted existing docs.Fixes #9692
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
N/A - this is fixing a type bug
Documentation
N/A - this is fixing a bug
Changesets
feat:,fix:,perf:,docs:, orchore:.