fix(reporter): include failure screenshot attachments in JUnit report#9905
Open
mixelburg wants to merge 4 commits intovitest-dev:mainfrom
Open
fix(reporter): include failure screenshot attachments in JUnit report#9905mixelburg wants to merge 4 commits intovitest-dev:mainfrom
mixelburg wants to merge 4 commits intovitest-dev:mainfrom
Conversation
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Collaborator
|
This shouldn't be |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9904
When browser mode is configured with
screenshotFailures: true, screenshots are captured on test failures and stored asinternal:failureScreenshotartifacts on the task. However, the JUnit reporter was not referencing these screenshots in its XML output, making it impossible for CI systems to correlate failures with their screenshots.This PR emits a
<system-out>element containing[[ATTACHMENT|/path/to/screenshot.png]]for each failure screenshot artifact on a failed test case. The[[ATTACHMENT|...]]convention is widely supported by CI systems (GitLab, Jenkins, GitHub Actions test report parsers, etc.).Changes
packages/vitest/src/node/reporters/junit.ts— after emitting<failure>elements, iterate overtask.artifactsforinternal:failureScreenshotartifacts and emit their path via<system-out>[[ATTACHMENT|...]]</system-out>test/cli/test/reporters/reporters.test.ts— add unit test verifying the[[ATTACHMENT|...]]is emitted in the JUnit output when a failed test has a failure screenshot artifact