fix(mocker): lazily import createFilter to respect optional vite peer dep#9919
Open
Hassad674 wants to merge 1 commit intovitest-dev:mainfrom
Open
fix(mocker): lazily import createFilter to respect optional vite peer dep#9919Hassad674 wants to merge 1 commit intovitest-dev:mainfrom
Hassad674 wants to merge 1 commit intovitest-dev:mainfrom
Conversation
… peer dep
Replace the static `import { createFilter } from 'vite'` with a
dynamic import inside the buildStart hook so that importing
`@vitest/mocker/node` no longer fails when vite is not installed.
Fixes vitest-dev#9915.
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9915
The static
import { createFilter } from 'vite'inhoistMocksPlugin.tscauses@vitest/mocker/nodeto fail withERR_MODULE_NOT_FOUNDwhen vite is not installed, even though vite is declared as an optional peer dependency.The fix moves the
createFilterimport into a dynamicawait import('vite')inside thebuildStarthook. SincebuildStartalways runs beforetransformin both Vite and Rollup, the filter is guaranteed to be initialized before any file is processed. When no custom filter is provided and vite isn't available, the plugin gracefully accepts all files.All other vite imports in the mocker package are already
import type(erased at compile time) — this was the only runtime value import.