Skip to content

fix: do not throw when browser mode is used without explicit projects (#9801) #9938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oilater wants to merge 4 commits into
base: main
Choose a base branch
from
+12 −1
Open

fix: do not throw when browser mode is used without explicit projects (#9801) #9938

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
420638d
fix: allow browser mode without explicit projects (#9801)
oilater Mar 21, 2026
ba4c21c
fix: inline projects check in browser validation logic
oilater Mar 21, 2026
90cd1e9
Merge branch 'main' into fix/9801-allow-browser-without-projects
oilater Mar 21, 2026
ed71f88
fix: allow browser mode without explicit projects when instances are …
oilater Mar 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/vitest/src/node/core.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,7 @@ export class Vitest {

if (this._cliOptions.browser?.enabled) {
const browserProjects = this.projects.filter(p => p.config.browser.enabled)
if (!browserProjects.length) {
if (!browserProjects.length && !this.config.browser?.instances?.length) {
Copy link
Copy Markdown
Member

@sheremet-va sheremet-va Mar 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be needed because instances inject new projects

throw new Error(`Vitest received --browser flag, but no project had a browser configuration.`)
}
}
Expand Down
11 changes: 11 additions & 0 deletions test/cli/test/config/browser-configs.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,17 @@ test('filters projects with a wildcard', async () => {
])
})

test('allows browser mode without projects', async () => {
await vitest({}, {
browser: {
enabled: true,
headless: true,
provider: playwright(),
instances: [{ browser: 'chromium' }],
},
})
})

test('assigns names as browsers in a custom project', async () => {
const { projects } = await vitest({}, {
projects: [
Expand Down
Loading