Skip to content

fix: prevent duplicate bench result table for top-level bench() calls #9968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
restareaByWeezy wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −1
Open

fix: prevent duplicate bench result table for top-level bench() calls #9968

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ab201e
fix: prevent duplicate bench result table for top-level bench() calls
restareaByWeezy Mar 25, 2026
9d15ec8
Merge branch 'main' into fix/top-level-bench-duplicate-output
restareaByWeezy Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/vitest/src/runtime/runners/benchmark.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,13 @@ async function runBenchmarkSuite(suite: Suite, runner: NodeBenchmarkRunner) {
suite.result!.duration = performance.now() - start
suite.result!.state = 'pass'

updateTask('suite-finished', suite)
// Don't emit suite-finished for the root file suite here. The general runSuite
// wrapper that calls runner.runSuite() will emit suite-finished for the file
// after this returns. Emitting it here would cause a duplicate event for files
// with top-level bench() calls (i.e. bench() outside any describe()).
if (suite.file !== suite) {
updateTask('suite-finished', suite)
}
defer.resolve(null)

await defer
Expand Down
Loading