Skip to content

feat(experimental): add TestAttachment.bodyEncoding#9969

Merged
hi-ogawa merged 10 commits intovitest-dev:mainfrom
hi-ogawa:feat-add-testattachment-bodyencoding
Mar 31, 2026
Merged

feat(experimental): add TestAttachment.bodyEncoding#9969
hi-ogawa merged 10 commits intovitest-dev:mainfrom
hi-ogawa:feat-add-testattachment-bodyencoding

Conversation

@hi-ogawa
Copy link
Copy Markdown
Collaborator

@hi-ogawa hi-ogawa commented Mar 25, 2026

Description

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.
  • Please check Allow edits by maintainers to make review process faster. Note that this option is not available for repositories that are owned by Github organizations.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 25, 2026

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 63d7c9a
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/69cb2c75b7a426000802afb6
😎 Deploy Preview https://deploy-preview-9969--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@hi-ogawa hi-ogawa marked this pull request as ready for review March 25, 2026 09:53
sheremet-va
sheremet-va previously approved these changes Mar 28, 2026
Copy link
Copy Markdown
Member

@sheremet-va sheremet-va left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but it needs to have experimental tag to be released in the patch release

@hi-ogawa hi-ogawa changed the title feat: add TestAttachment.bodyEncoding feat(experimental): add TestAttachment.bodyEncoding Mar 31, 2026
@hi-ogawa
Copy link
Copy Markdown
Collaborator Author

Updated as experimental.

@sheremet-va sheremet-va disabled auto-merge March 31, 2026 10:24
@hi-ogawa hi-ogawa merged commit 89ca0e2 into vitest-dev:main Mar 31, 2026
15 of 16 checks passed
@hi-ogawa hi-ogawa deleted the feat-add-testattachment-bodyencoding branch March 31, 2026 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

annotate(.., { body: string }) expects string pre-encoded with base64 on UI and HTML report

2 participants