feat(api): add endpoint to update site aliases#551
Merged
saeedvaziry merged 3 commits intovitodeploy:2.xfrom Mar 21, 2025
Merged
feat(api): add endpoint to update site aliases#551saeedvaziry merged 3 commits intovitodeploy:2.xfrom
saeedvaziry merged 3 commits intovitodeploy:2.xfrom
Conversation
Member
|
Thanks for the PR. I will run the scribe:generate myself. however I would appreciate one test to cover this endpoint. |
Contributor
Author
|
Test added! It's possible that I'm just an idiot, but it might be worth adding to the contributing docs (or maybe just the readme?) that you need to manually create It only took 30 seconds for me to realise, but might help some people. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows the updating of a sites aliases using a PUT request. The request requires one property on the body, "aliases" - which is an array of strings.
I have not ran
scribe:generate(yet) - the entire scribe directory gets rewritten and I'm not familiar enough with scribe to know if this is the correct behaviour.I intend to continue adding more API functionality, but this is something that has a particular priority for me currently (hence PRing this alone first).