Adds downloading user games from Chess.com and cleans up downloading user games from Lichess.org #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitogit
reviewed
May 13, 2022
Comment on lines
1
to
+4
| colorama==0.4.4 | ||
| chess==1.5.0 | ||
| requests==2.20.0 | ||
| lichess>=0.1.9 |
Owner
There was a problem hiding this comment.
I had a problem installing this and had to change it to:
Suggested change
| colorama==0.4.4 | |
| chess==1.5.0 | |
| requests==2.20.0 | |
| lichess>=0.1.9 | |
| colorama==0.4.4 | |
| chess==1.5.0 | |
| requests==2.27.1 | |
| lichess>=0.1.9 |
This was the error
ERROR: Cannot install -r requirements.txt (line 4) and requests==2.20.0 because these package versions have conflicting dependencies.
The conflict is caused by:
The user requested requests==2.20.0
lichess 0.1.9 depends on requests==2.27.1
vitogit
reviewed
May 13, 2022
| archive_dates[len(archive_dates) - 1] = archive_dates[ | ||
| len(archive_dates) - 1].rstrip("\"]}") | ||
|
|
||
| with open("games.pgn", "w") as new_file: |
Owner
There was a problem hiding this comment.
I think we will need the max param also for chess.com
One way to do it is use parse the json from https://api.chess.com/pub/player/hikaru/games/2017/04 to count the number of games. and get the pgn with .pgn
vitogit
reviewed
May 13, 2022
|
|
||
| archives = http_response.read().decode("utf-8") | ||
| archives = archives.replace("{\"archives\":[\"", "\",\"") | ||
| archive_dates = archives.split("\",\"" + url_chessdotcom) |
Owner
There was a problem hiding this comment.
Would be better if the dates are sorted from recent to older. So you can always download the latest games by default.
vitogit
requested changes
May 13, 2022
Owner
vitogit
left a comment
vitogit
left a comment
There was a problem hiding this comment.
@vanderbilt-cs This pr is great I left some comments to make it better.. Thanks for the pr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following changes have been implemented in this PR:
lichessPython package.DS_Storesince it is unnecessary and already not included in.gitignoreREADME.mdon how to download user game data for Lichess or Chess.com and improved its readability