Skip to content

create reaction file immediately on edge creation#227

Merged
uiysg merged 10 commits intodevelopfrom
fix-code-editor-window
Mar 6, 2026
Merged

create reaction file immediately on edge creation#227
uiysg merged 10 commits intodevelopfrom
fix-code-editor-window

Conversation

@uiysg
Copy link
Contributor

@uiysg uiysg commented Mar 4, 2026

Previously, reaction files were only created when the user explicitly
saved the editor content. This caused the VSUM save to fail with
"Reaction files not found" when the editor was never opened.

Now, a reaction file is uploaded immediately when a new edge is drawn,
ensuring a valid reactionFileId is always present in the edge data
before the user attempts to save the VSUM.

@uiysg uiysg marked this pull request as draft March 4, 2026 22:38
@uiysg uiysg marked this pull request as ready for review March 5, 2026 13:05
@TsotneMikadze TsotneMikadze requested a review from ma-mirzaei March 6, 2026 10:46
@TsotneMikadze TsotneMikadze linked an issue Mar 6, 2026 that may be closed by this pull request
ma-mirzaei
ma-mirzaei previously approved these changes Mar 6, 2026
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 6, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
3 Security Hotspots

See analysis details on SonarQube Cloud

@uiysg uiysg requested a review from ma-mirzaei March 6, 2026 14:10
@uiysg uiysg merged commit 16b6e86 into develop Mar 6, 2026
3 of 4 checks passed
@uiysg uiysg deleted the fix-code-editor-window branch March 6, 2026 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Store reaction file after opening the editor tab immediatlly

2 participants