Merged
Conversation
…and the hooks files
added test folder structure and implemented some tests for the utils …
- Organized test folder structure for better maintainability. - Implemented additional tests for utility functions and hooks to improve code coverage and reliability.
- Updated test file to replace direct function references with mock functions for verifyOtp and resendOtp. - Improved test clarity and maintainability by using consistent mock naming conventions. - Ensured that tests correctly validate the behavior of the OtpVerificationPage component.
- Wrapped jest timer functions in act() to ensure proper handling of state updates. - Renamed test case to reflect validation error for submitting a code that is too short. - Added user interaction to simulate entering a short verification code, enhancing test coverage.
- Updated the test to use the correct mock function name for verifying OTP, improving test accuracy and clarity.
Refactor and enhance utility and hook tests
- Added tests for various OTP submission scenarios, including edge cases for invalid inputs. - Improved test descriptions for better clarity and understanding of test intentions. - Ensured comprehensive coverage of the OtpVerificationPage functionality.
Enhance OtpVerificationPage tests with additional scenarios
- Updated merge point calculation to only consider UML inheritance edges, improving clarity in visual representation. - Enhanced edge highlighting logic to differentiate between selected and hovered states, ensuring accurate visual feedback. - Adjusted marker rendering for merged edges to maintain UML semantics, specifically for composition and aggregation relationships. - Improved comments for better understanding of the merge logic and edge rendering behavior.
…eeded to be changed
Refactor UML relationship rendering and merge point logic
create reaction file immediately on edge creation
|
arlange
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.