feat: Add Redirect map #1181
Open
feat: Add Redirect map #1181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArneGudermann
added
feature
phorward
added
viur-meeting
sveneberth
requested changes
Oct 22, 2024
Co-authored-by: Sven Eberth <[email protected]>
sveneberth
previously approved these changes
Oct 22, 2024
Co-authored-by: Sven Eberth <[email protected]>
sveneberth
approved these changes
Oct 22, 2024
phorward
requested changes
Oct 22, 2024
Member
phorward
left a comment
phorward
left a comment
There was a problem hiding this comment.
Hi @ArneGudermann, I would like to combine this pull request with #1218 (#803) to get rid of the SEO-stuff. Your redirect-map is part of it, but should come from a SkelModule.
If this PR is not necessary for current customer projects, I would like to shift it to v3.8.
Member
|
First step would be to integrate such a module to allow user-defined redirects. |
Member
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1168
This PR adds an Redirect handler with two modes.
In the normal mode its only matches the key in the dict.
In the advanced mode you can provides key with wildcards like: