Skip to content

feat: ✨ add character length indicator for commit message#310

Open
gabolera wants to merge 14 commits intovivaxy:masterfrom
gabolera:master
Open

feat: ✨ add character length indicator for commit message#310
gabolera wants to merge 14 commits intovivaxy:masterfrom
gabolera:master

Conversation

@gabolera
Copy link
Copy Markdown

@gabolera gabolera commented Mar 9, 2023

Added count visual characters for help user as not write a big commit

  • Short recommended limit 50
  • Long recommended limit: 72 (maybe this value is wrong and can change)

PR for this discussion #293

Print of feature
Screenshot_27

@gabolera gabolera changed the title add character length indicator for commit message feat: ✨ add character length indicator for commit message Mar 9, 2023
@yi-Xu-0100 yi-Xu-0100 added the wait-to-build PR wait to build package. label Mar 10, 2023
@github-actions github-actions Bot removed the wait-to-build PR wait to build package. label Mar 10, 2023
@github-actions
Copy link
Copy Markdown
Contributor

The beta extension of this pull has been built in the workflow! 🎉
Download vscode-conventional-commits-e8d25c4.vsix in artifacts. 🚀

@yi-Xu-0100 yi-Xu-0100 added the wait-to-build PR wait to build package. label Mar 11, 2023
@github-actions github-actions Bot removed the wait-to-build PR wait to build package. label Mar 11, 2023
@github-actions
Copy link
Copy Markdown
Contributor

The beta extension of this pull has been built in the workflow! 🎉
Download vscode-conventional-commits-dcb7e09.vsix in artifacts. 🚀

@yi-Xu-0100 yi-Xu-0100 added the wait-to-build PR wait to build package. label Mar 11, 2023
@github-actions github-actions Bot removed the wait-to-build PR wait to build package. label Mar 11, 2023
@github-actions
Copy link
Copy Markdown
Contributor

The beta extension of this pull has been built in the workflow! 🎉
Download vscode-conventional-commits-1c8cfdf.vsix in artifacts. 🚀

add getSubjectMaxLengthEnum() and getBodyMaxLengthEnum() for get value defined on commitlint rules

vivaxy#293
this modification has solved error in build

 Argument of type 'unknown' is not assignable to parameter of type 'string | Error'
@gabolera gabolera closed this Sep 28, 2023
@gabolera gabolera reopened this Sep 28, 2023
…body

add getSubjectMaxLengthEnum() and getBodyMaxLengthEnum() for get value defined on commitlint rules

vivaxy#293
…body

add getSubjectMaxLengthEnum() and getBodyMaxLengthEnum() for get value defined on commitlint rules

vivaxy#293
@gabolera
Copy link
Copy Markdown
Author

gabolera commented Sep 28, 2023

@yi-Xu-0100 @vivaxy You can test?

Context of editions #293 (comment)

#293

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants