refactor: convert to npm workspaces monorepo#232
Merged
akabekobeko merged 5 commits intomainfrom Mar 17, 2026
Merged
Conversation
Move @vivliostyle/vfm package into packages/vfm/ and configure npm workspaces at the root. Pin @types/unist and @types/mdast versions in root devDependencies to prevent type incompatibilities from hoisting. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
u1f992
reviewed
Mar 15, 2026
Member
u1f992
left a comment
There was a problem hiding this comment.
ほぼファイル移動のみなので、この時点では基本的には問題なさそうです!ビルドとテストも確認できました。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vivliostyle 開発者会議で提案のあったモノレポ対応を実施しました。pnpm にするか迷いましたが、とりあえず npm workspace 形式としています。
すでに開発されている remark プラグインと親和性があるか?などの観点からレビューいただけると助かります!
Summary
@vivliostyle/vfmパッケージをpackages/vfm/に移動package.jsonに workspaces 設定と、型パッケージのバージョン固定用devDependenciesを追加.claude/settings.local.jsonを.gitignoreに追加Test plan
npm run buildでビルド成功を確認npm testで全 117 テストがパスすることを確認🤖 Generated with Claude Code