Skip to content

test: testcase fixes for only masterKey can operate on the mfa #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: 7-vizmo
Choose a base branch
from
Open

test: testcase fixes for only masterKey can operate on the mfa #10

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2257684
test: testcase fixes for only masterKey can operate on the mfa
nikhilcares22 Aug 18, 2025
a680b22
Update spec/AuthenticationAdapters.spec.js
nikhilcares22 Aug 18, 2025
f615a49
Update spec/AuthenticationAdapters.spec.js
nikhilcares22 Aug 18, 2025
06e06be
Update spec/AuthenticationAdapters.spec.js
nikhilcares22 Aug 18, 2025
8b400ab
Update spec/AuthenticationAdapters.spec.js
nikhilcares22 Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions spec/AuthenticationAdapters.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1534,7 +1534,7 @@ describe('OTP TOTP auth adatper', () => {
const token = totp.generate();
await user.save(
{ authData: { mfa: { secret: secret.base32, token } } },
{ sessionToken: user.getSessionToken() }
{ useMasterKey: true }
);
const response = user.get('authDataResponse');
expect(response.mfa).toBeDefined();
Expand All @@ -1557,7 +1557,7 @@ describe('OTP TOTP auth adatper', () => {
const token = totp.generate();
await user.save(
{ authData: { mfa: { secret: secret.base32, token } } },
{ sessionToken: user.getSessionToken() }
{ useMasterKey: true }
);
const response = await request({
headers,
Expand Down Expand Up @@ -1603,7 +1603,7 @@ describe('OTP TOTP auth adatper', () => {
const token = totp.generate();
await user.save(
{ authData: { mfa: { secret: secret.base32, token } } },
{ sessionToken: user.getSessionToken() }
{ useMasterKey: true }
);

const new_secret = new OTPAuth.Secret();
Expand All @@ -1618,7 +1618,7 @@ describe('OTP TOTP auth adatper', () => {
{
authData: { mfa: { secret: new_secret.base32, token: new_token, old: totp.generate() } },
},
{ sessionToken: user.getSessionToken() }
{ useMasterKey: true }
);
await user.fetch({ useMasterKey: true });
expect(user.get('authData').mfa.secret).toEqual(new_secret.base32);
Expand All @@ -1637,7 +1637,7 @@ describe('OTP TOTP auth adatper', () => {
const token = totp.generate();
await user.save(
{ authData: { mfa: { secret: secret.base32, token } } },
{ sessionToken: user.getSessionToken() }
{ useMasterKey: true }
);

const new_secret = new OTPAuth.Secret();
Expand Down Expand Up @@ -1673,8 +1673,9 @@ describe('OTP TOTP auth adatper', () => {
const token = totp.generate();
await user.save(
{ authData: { mfa: { secret: secret.base32, token } } },
{ sessionToken: user.getSessionToken() }
{ useMasterKey: true }
);
await user.fetch({ useMasterKey: true });
await expectAsync(Parse.User.logIn('username', 'password')).toBeRejectedWith(
new Parse.Error(Parse.Error.OTHER_CAUSE, 'Missing additional authData mfa')
);
Expand All @@ -1693,7 +1694,7 @@ describe('OTP TOTP auth adatper', () => {
const token = totp.generate();
await user.save(
{ authData: { mfa: { secret: secret.base32, token } } },
{ sessionToken: user.getSessionToken() }
{ useMasterKey: true }
);
await expectAsync(
request({
Expand Down Expand Up @@ -1749,10 +1750,9 @@ describe('OTP SMS auth adatper', () => {

it('can enroll', async () => {
const user = await Parse.User.signUp('username', 'password');
const sessionToken = user.getSessionToken();
const spy = spyOn(mfa, 'sendSMS').and.callThrough();
await user.save({ authData: { mfa: { mobile: '+11111111111' } } }, { sessionToken });
await user.fetch({ sessionToken });
await user.save({ authData: { mfa: { mobile: '+11111111111' } } }, { useMasterKey: true });
await user.fetch({ sessionToken: user.getSessionToken() });
expect(user.get('authData')).toEqual({ mfa: { status: 'disabled' } });
expect(spy).toHaveBeenCalledWith(code, '+11111111111');
await user.fetch({ useMasterKey: true });
Expand All @@ -1761,8 +1761,8 @@ describe('OTP SMS auth adatper', () => {
expect(authData['+11111111111']).toBeDefined();
expect(Object.keys(authData['+11111111111'])).toEqual(['token', 'expiry']);

await user.save({ authData: { mfa: { mobile, token: code } } }, { sessionToken });
await user.fetch({ sessionToken });
await user.save({ authData: { mfa: { mobile, token: code } } }, { useMasterKey: true });
await user.fetch({ sessionToken: user.getSessionToken() });
expect(user.get('authData')).toEqual({ mfa: { status: 'enabled', type: 'SMS' } });
});

Expand All @@ -1771,12 +1771,12 @@ describe('OTP SMS auth adatper', () => {
const spy = spyOn(mfa, 'sendSMS').and.callThrough();
await user.save(
{ authData: { mfa: { mobile: '+11111111111' } } },
{ sessionToken: user.getSessionToken() }
{ useMasterKey: true }
);

await user.save(
{ authData: { mfa: { mobile, token: code } } },
{ sessionToken: user.getSessionToken() }
{ useMasterKey: true }
);

spy.calls.reset();
Expand Down
Loading