Fix restart command and providing argument to subcommands#4
Merged
vjardin merged 2 commits intovjardin:mainfrom Nov 12, 2025
thbtcllt:main
Merged
Fix restart command and providing argument to subcommands#4vjardin merged 2 commits intovjardin:mainfrom thbtcllt:main
vjardin merged 2 commits intovjardin:mainfrom
thbtcllt:main
Conversation
added 2 commits
November 10, 2025 17:28
block sequence for the restart is incorrect. Regarding https://datasheet.lcsc.com/lcsc/2412091105_Flex-Power-Modules-BMR4802112-032_C6132194.pdf it is "ERIC" and not "00000000". With this value restart is successfull for BMR456
Call to reset optind is done too early and the whole arguments are provided to the subcommands that fails due to the unexpected value. Just move the reset of optind after settings arg/argv for the subcommand.
Owner
|
lgtm, merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.